Fix documentation, grammar, and spelling in bindings H-I#19534
Merged
jlaur merged 8 commits intoopenhab:mainfrom Nov 30, 2025
Merged
Fix documentation, grammar, and spelling in bindings H-I#19534jlaur merged 8 commits intoopenhab:mainfrom
jlaur merged 8 commits intoopenhab:mainfrom
Conversation
lsiepel
requested review from
Cossey,
J-N-K,
Skinah,
Sonic-Amiga,
Wire82,
andrewfg,
bruestel,
chingon007,
digitaldan,
hmerk,
kgoderis,
lewei50,
matchews,
paulianttila,
peuter,
pgfeller,
ramack and
tavalin
as code owners
digitaldan
approved these changes
Oct 23, 2025
lsiepel
changed the title
pgfeller
reviewed
Oct 25, 2025
pgfeller
approved these changes
Oct 25, 2025
Contributor
pgfeller
left a comment
pgfeller
left a comment
There was a problem hiding this comment.
Review of owned file(s). LGTM.
Minor suggestion.
Contributor
Author
|
Failing build can be fixed by #19650 |
jlaur
requested changes
Nov 25, 2025
Contributor
jlaur
left a comment
jlaur
left a comment
There was a problem hiding this comment.
Thanks for the many corrections! And sorry for the slow review. A few comments added for this one.
You might want to go through the other PR's already checking for "Thing" being changed to "thing" in README's. I believe we usually use the term "Thing" to make it clear it's an openHAB concept.
bundles/org.openhab.binding.haassohnpelletstove/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
....openhab.binding.haywardomnilogic/src/main/resources/OH-INF/i18n/haywardomnilogic.properties
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.hdanywhere/src/main/resources/OH-INF/i18n/hdanywhere.properties
Show resolved
Hide resolved
bundles/org.openhab.binding.ipcamera/src/main/resources/OH-INF/i18n/ipcamera.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Co-authored-by: Patrik Gfeller <patrik.gfeller@proton.me> Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lsiepel
requested review from
a team,
andylintner and
jsetton
as code owners
lsiepel
commented
Nov 29, 2025
...ab.binding.haassohnpelletstove/src/main/resources/OH-INF/i18n/haassohnpelletstove.properties
Outdated
Show resolved
Hide resolved
lsiepel
commented
Nov 29, 2025
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>
jlaur
reviewed
Nov 29, 2025
jlaur
reviewed
Nov 29, 2025
jsetton
approved these changes
Nov 29, 2025
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.